gpui: Fix BGRA conversion for SVG rendering

[nakashima-hikaru]

Description

Fixes swapped red/blue channels when rendering SVG images.

Describe the bug

When rendering a full-color SVG into an Image object using Image::from_bytes(ImageFormat::Svg, ...) on macOS, the resulting bitmap has its Red and Blue channels swapped. For example, a color specified as #38BDF8 (Light Blue) in the SVG source appears as yellowish in the rendered GPUI view.

Steps to reproduce

1. Create a GPUI application.
2. Generate or load an SVG string containing a specific color, for example:

   <svg xmlns="http://www.w3.org/2000/svg" width="100" height="100">
     <rect width="100" height="100" fill="#38BDF8"/>
   </svg>

3. Load this SVG into an Image object:

   let image = Arc::new(Image::from_bytes(
       ImageFormat::Svg,
       svg_string.into_bytes(),
   ));

4. Display this image in a view using an img() element.

Expected behavior

The rectangle should be rendered in Light Blue (#38BDF8).

Actual behavior

The rectangle is rendered in Yellowish Color (#F8BD38).

Self-Review Checklist:

• I've reviewed my own diff for quality, security, and reliability
• Unsafe blocks (if any) have justifying comments
• The content is consistent with the UI/UX checklist
• Tests cover the new/changed behavior
• Performance impact has been considered and is acceptable

Closes #ISSUE

Release Notes:

• Fixed swapped color channels when pasting SVG images from the clipboard.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @nakashima-hikaru on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[nakashima-hikaru]

@cla-bot check

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @nakashima-hikaru on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[nakashima-hikaru]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[MrSubidubi]

Nice find and very much appreciate the test you added for this!

I went ahead and removed the parameter altogether, given that it is now true throughout the codebase and I think that other consumers would probably expect the image to always be in the proper color space.

In any case, thank you for this and congratulations to your first contribution! 🎉

[nakashima-hikaru]

Thanks a lot for the review and for cleaning that up.
As a fan of Zed, I’ll be cheering the project on.