Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Anthony-Eid
approved these changes
Mar 31, 2026
rtfeldman
deleted the
AI-120/investigate-reference-count-cycle-on-tooltips
branch
KlausUllrich
pushed a commit
to KlausUllrich/zed
that referenced
this pull request
Apr 8, 2026
## Summary - break tooltip back-references from stored callbacks and tasks with weak handles - keep the tooltip controller as the sole strong owner of tooltip lifecycle state - add a regression test that exercises the visible-tooltip ownership graph directly ## Testing - cargo test -p gpui tooltip_is_released_when_its_owner_disappears --lib Closes AI-120 Release Notes: - Fixed a tooltip memory leak.
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
## Summary - break tooltip back-references from stored callbacks and tasks with weak handles - keep the tooltip controller as the sole strong owner of tooltip lifecycle state - add a regression test that exercises the visible-tooltip ownership graph directly ## Testing - cargo test -p gpui tooltip_is_released_when_its_owner_disappears --lib Closes AI-120 Release Notes: - Fixed a tooltip memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes AI-120
Release Notes: