workspace: Add basic pane property tests and fix navigation bug#52871
Merged
probably-neb merged 3 commits intozed-industries:mainfrom Apr 23, 2026
Merged
workspace: Add basic pane property tests and fix navigation bug#52871probably-neb merged 3 commits intozed-industries:mainfrom
probably-neb merged 3 commits intozed-industries:mainfrom
Conversation
Collaborator
|
nice! this is super cool. If you wouldn't mind fixing the conflict in |
probably-neb
approved these changes
Apr 15, 2026
21bf675 to
4253b2e
Compare
4253b2e to
bf2a923
Compare
Contributor
Author
Awesome! I've just done so. |
33798d3 to
895ebe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds very basic property tests for navigation within a single pane, with these operations:
It primarily tests that a single backward or forward navigation step results in the correct item being active. It doesn't currently test that going back multiple times in a row results in the correct items because the deduplication logic that Zed uses for this turned out to be hard to model in an "obviously correct" way, and I aimed to keep it really simple.
These tests surfaced a navigation bug that this PR also fixes, where replacing an inactive preview tab would sometimes corrupt the navigation history.
Before:
before.mov
After:
after.mov
Self-Review Checklist:
Release Notes: