Fix/devcontainer compose labels#53057
Merged
KyleBarton merged 4 commits intozed-industries:mainfrom Apr 3, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
guild
zed-codeowner-coordinator
Bot
requested review from
a team,
SomeoneToIgnore and
reflectronic
and removed request for
a team
SomeoneToIgnore
requested review from
KyleBarton
and removed request for
SomeoneToIgnore
KyleBarton
approved these changes
Apr 3, 2026
Collaborator
|
Thanks for the fix! I went ahead and moved the data type for these labels to a Map. If we're going to have to coerce types one way or another, the map seems like a better representation |
Contributor
Author
Yeah, Hashmap would be better |
zed-zippy
Bot
added
the
PR state:needs review
rtfeldman
pushed a commit
that referenced
this pull request
Apr 4, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #53042 Release Notes: - Fixed dev container failing to open when Docker Compose file contains `labels` --------- Co-authored-by: KyleBarton <kjb@initialcapacity.io>
MrSubidubi
removed
the
PR state:needs review
zed-zippy
Bot
added
the
PR state:needs review
dinocosta
removed
the
PR state:needs review
im-0
added a commit
to im-0/fedora-rpm.zed
that referenced
this pull request
Apr 11, 2026
This fixes zed-industries/zed#53042 by adding patches from zed-industries/zed#53057
This was referenced Apr 13, 2026
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#53042 Release Notes: - Fixed dev container failing to open when Docker Compose file contains `labels` --------- Co-authored-by: KyleBarton <kjb@initialcapacity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Closes #53042
Closes #53482
Closes #53769
Release Notes:
labels