terminal: Bind Alt+F4 to Close Window in the terminal keymap#53091
terminal: Bind Alt+F4 to Close Window in the terminal keymap#53091kubkon merged 2 commits intozed-industries:mainfrom
Conversation
|
Looks like you have an unrelated commit in your branch? Also, is it possible to just do this using a default keybind in the |
3d2bda1 to
6822387
Compare
|
Thanks for calling both of these out. I rebased the branch onto main to remove the unrelated commit, and I reworked the fix to use the Windows Terminal keymap context instead of special-casing TerminalView. The PR now binds Alt+F4 to workspace::CloseWindow in that context and adds a regression test that checks the built-in Windows keymap entry. Validation: cargo test -p settings windows_terminal_keymap_closes_window_on_alt_f4. |
|
Also passing by and noting that I'll leave the decision about the binding to @\reflectronic . |
Agreed about the test - removed. The binding looks fine to me tho. |
Closes #52774 ## Summary - Bind Windows `Alt+F4` to `workspace::CloseWindow` in the `Terminal` keymap context - Add a regression test covering the built-in Windows terminal keymap entry ## Why When the integrated terminal is focused, `Alt+F4` should close the window instead of falling through to terminal keystroke handling. Handling this in the Windows `Terminal` keymap keeps the fix aligned with the rest of the terminal shortcut overrides. ## Validation - `cargo test -p settings windows_terminal_keymap_closes_window_on_alt_f4` Release Notes: - Fixed Alt+F4 on Windows so Zed closes even when the integrated terminal is focused. --------- Co-authored-by: Jakub Konka <[email protected]>
…ustries#53091) Closes zed-industries#52774 ## Summary - Bind Windows `Alt+F4` to `workspace::CloseWindow` in the `Terminal` keymap context - Add a regression test covering the built-in Windows terminal keymap entry ## Why When the integrated terminal is focused, `Alt+F4` should close the window instead of falling through to terminal keystroke handling. Handling this in the Windows `Terminal` keymap keeps the fix aligned with the rest of the terminal shortcut overrides. ## Validation - `cargo test -p settings windows_terminal_keymap_closes_window_on_alt_f4` Release Notes: - Fixed Alt+F4 on Windows so Zed closes even when the integrated terminal is focused. --------- Co-authored-by: Jakub Konka <[email protected]>
Closes #52774
Summary
Alt+F4toworkspace::CloseWindowin theTerminalkeymap contextWhy
When the integrated terminal is focused,
Alt+F4should close the window instead of falling through to terminal keystroke handling. Handling this in the WindowsTerminalkeymap keeps the fix aligned with the rest of the terminal shortcut overrides.Validation
cargo test -p settings windows_terminal_keymap_closes_window_on_alt_f4Release Notes: