Skip to content

editor: Hide run button in gutter for unsaved buffers#53195

Merged
yara-blue merged 5 commits intozed-industries:mainfrom
Dnreikronos:fix/hide-run-button-unsaved-buffers
Apr 20, 2026
Merged

editor: Hide run button in gutter for unsaved buffers#53195
yara-blue merged 5 commits intozed-industries:mainfrom
Dnreikronos:fix/hide-run-button-unsaved-buffers

Conversation

@Dnreikronos
Copy link
Copy Markdown
Contributor

@Dnreikronos Dnreikronos commented Apr 5, 2026 •
edited
Loading

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #52942

Demo:

Before:

before.mp4

After:

after.mp4

Release Notes:

  • Fixed play button appearing in gutter for unsaved buffers where clicking it was a no-op.

@Dnreikronos
Fix: Hide run button in gutter for unsaved buffers
dc52ef8 
Skip runnable detection when the buffer has no associated file on disk,
since running an unsaved buffer is a no-op.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 5, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator Bot requested review from a team, dinocosta and nathansobo and removed request for a team April 5, 2026 14:18
@MrSubidubi MrSubidubi changed the title Fix: Hide run button in gutter for unsaved buffers editor: Hide run button in gutter for unsaved buffers Apr 6, 2026
Veykril
Veykril approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril self-assigned this Apr 20, 2026
@Veykril Veykril enabled auto-merge (squash) April 20, 2026 08:22
@Veykril
Copy link
Copy Markdown
Member

Veykril commented Apr 20, 2026

needs a rustfmt

auto-merge was automatically disabled April 20, 2026 13:19

Head branch was pushed to by a user without write access

@Dnreikronos
Copy link
Copy Markdown
Contributor Author

Dnreikronos commented Apr 20, 2026

needs a rustfmt

Adjusted!

@yara-blue yara-blue merged commit 1e04818 into zed-industries:main Apr 20, 2026
31 checks passed
@yara-blue
Copy link
Copy Markdown
Member

yara-blue commented Apr 20, 2026

thanks!

@Dnreikronos
Copy link
Copy Markdown
Contributor Author

Dnreikronos commented Apr 20, 2026

thanks!

Thank you @yara-blue and @Veykril for your time invested <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

@nathansobo nathansobo Awaiting requested review from nathansobo nathansobo was automatically assigned from zed-industries/core-team

@dinocosta dinocosta Awaiting requested review from dinocosta dinocosta was automatically assigned from zed-industries/core-team

Assignees

@Veykril Veykril

@yara-blue yara-blue

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Play button appears in gutter for unsaved buffers, but is a no-op

5 participants

@Dnreikronos @Veykril @yara-blue @nathansobo @zelenenka