git_ui: Strip ANSI escape codes from git command output#53444
Merged
Veykril merged 3 commits intozed-industries:mainfrom Apr 9, 2026
Merged
git_ui: Strip ANSI escape codes from git command output#53444Veykril merged 3 commits intozed-industries:mainfrom
Veykril merged 3 commits intozed-industries:mainfrom
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
zed-codeowner-coordinator
Bot
requested review from
a team,
Veykril and
kubkon
and removed request for
a team
Contributor
|
Since this was merged, I request @esthertrapadoux to close #43817. |
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
…es#53444) When git commands (push, pull, hooks...) produce output containing ANSI escape sequences for colors or formatting, Zed was displaying them as raw escape codes in the output buffer, making the output hard to read. This simply escapes ANSI from the git output ### Before and After <table> <tr> <th align="center">Before</th> <th align="center">After</th> </tr> <tr> <td> <img width="882" height="862" alt="Screenshot 2026-04-08 at 21 13 07" src="https://github.com/user-attachments/assets/58731e80-d864-47ca-8983-d0e86e924843" /> </td> <td> <img width="882" height="862" alt="Screenshot 2026-04-08 at 21 15 14" src="https://github.com/user-attachments/assets/7649200a-2d82-4442-88da-e231304911a8" /> </td> </tr> </table> Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Related to zed-industries#43817. This PR only addresses the escaping of the ANSI codes; colors and other stuff are not handled Release Notes: - Fixed ANSI escape codes being displayed as raw text in git command output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When git commands (push, pull, hooks...) produce output containing ANSI escape sequences for colors or formatting, Zed was displaying them as raw escape codes in the output buffer, making the output hard to read. This simply escapes ANSI from the git output
Before and After
Self-Review Checklist:
Related to #43817. This PR only addresses the escaping of the ANSI codes; colors and other stuff are not handled
Release Notes: