sidebar: Filter thread groups by remote host identity#53918
Merged
Conversation
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Richard Feldman <oss@rtfeldman.com> Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Richard Feldman <oss@rtfeldman.com> Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Anthony-Eid
changed the title
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
mikayla-maki
approved these changes
Apr 14, 2026
piper-of-dawn
pushed a commit
to piper-of-dawn/zed
that referenced
this pull request
Apr 25, 2026
…#53918) ### Summary Follow up on: zed-industries#53550 Threads in the sidebar are now filtered by remote connection in addition to path list. Previously, two different machines with the same absolute project paths (e.g. both at `/home/user/project`) would have their threads merged into a single sidebar group. Now each remote host gets its own group. To support this, this PR introduces `RemoteConnectionIdentity`, a normalized subset of `RemoteConnectionOptions` that includes only the fields relevant for identity matching (e.g. SSH host + username + port, but not nickname or connection timeout). All remote host comparisons in the sidebar, thread metadata store, and workspace persistence now go through `same_remote_connection_identity()` instead of raw `==` on `RemoteConnectionOptions`. #### Follow Up on remoting for sidebar 1. Make the neighbor in archive thread fallback to the main git worktree instead of the next thread 2. Start implementing remote git operations that archive feature depends on 3. Make remote connection pool equality use `RemoteConnectionIdentity` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A --------- Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com> Co-authored-by: Richard Feldman <oss@rtfeldman.com>
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
…#53918) ### Summary Follow up on: zed-industries#53550 Threads in the sidebar are now filtered by remote connection in addition to path list. Previously, two different machines with the same absolute project paths (e.g. both at `/home/user/project`) would have their threads merged into a single sidebar group. Now each remote host gets its own group. To support this, this PR introduces `RemoteConnectionIdentity`, a normalized subset of `RemoteConnectionOptions` that includes only the fields relevant for identity matching (e.g. SSH host + username + port, but not nickname or connection timeout). All remote host comparisons in the sidebar, thread metadata store, and workspace persistence now go through `same_remote_connection_identity()` instead of raw `==` on `RemoteConnectionOptions`. #### Follow Up on remoting for sidebar 1. Make the neighbor in archive thread fallback to the main git worktree instead of the next thread 2. Start implementing remote git operations that archive feature depends on 3. Make remote connection pool equality use `RemoteConnectionIdentity` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A --------- Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com> Co-authored-by: Richard Feldman <oss@rtfeldman.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on: #53550
Threads in the sidebar are now filtered by remote connection in addition to path list. Previously, two different machines with the same absolute project paths (e.g. both at
/home/user/project) would have their threads merged into a single sidebar group. Now each remote host gets its own group.To support this, this PR introduces
RemoteConnectionIdentity, a normalized subset ofRemoteConnectionOptionsthat includes only the fields relevant for identity matching (e.g. SSH host + username + port, but not nickname or connection timeout). All remote host comparisons in the sidebar, thread metadata store, and workspace persistence now go throughsame_remote_connection_identity()instead of raw==onRemoteConnectionOptions.Follow Up on remoting for sidebar
RemoteConnectionIdentitySelf-Review Checklist:
Release Notes: