OSC8-URIs support in terminal#54322
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
yara-blue
force-pushed
the
fix-OSC8-URIs
branch
from
da16323 to
e585062
Compare
Veykril
reviewed
Apr 20, 2026
Member
There was a problem hiding this comment.
I don't know about these changes. These functions are not just used for the terminal after all, so handing OSC 8 here doesn't feel right? Might be better to duplicate for osc 8 functionality instead
Member
Author
There was a problem hiding this comment.
ty you are right, makes no sense for "URLs" which is what this function is about.
I'll move it to terminal tomorrow and ping you 👍
yara-blue
force-pushed
the
fix-OSC8-URIs
branch
from
9f2a65a to
07adef0
Compare
Veykril
approved these changes
Apr 23, 2026
2 tasks
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#39339 Release Notes: - Fixed hyperlinks in the terminal on UNIX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Closes #39339
Release Notes: