language_model: Fix ImageSize storing pre-downscale dimensions#54357
Merged
MrSubidubi merged 1 commit intozed-industries:mainfrom Apr 21, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
SomeoneToIgnore
added
the
area:ai
MrSubidubi
requested changes
Apr 20, 2026
Member
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this!
This seems like a good fix, can we add a test for this to make sure this does not regress?
When images are resized to meet provider size constraints (Anthropic's 1568px limit or the 5MB encoded-PNG cap), the stored ImageSize was still recording the original width/height rather than the final post-downscale dimensions. This caused incorrect token estimation via estimate_tokens() since it uses width * height / 750. Use processed_image.dimensions() after all downscale passes so that ImageSize reflects the actual image sent to the provider. Release Notes: - N/A
dastrobu
force-pushed
the
fix/image-size-after-downscale
branch
from
37d10b6 to
282feaf
Compare
Contributor
Author
@MrSubidubi absolutely, thanks for the quick feedback. Test cases is updated, please review again. |
MrSubidubi
changed the title
ImageSize storing pre-downscale dimensions
MrSubidubi
approved these changes
Apr 21, 2026
Member
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Nice find, fix and test update. Thank you for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When images are resized to meet provider size constraints (Anthropic's 1568px limit or the 5MB encoded-PNG cap), the stored ImageSize was still recording the original width/height rather than the final post-downscale dimensions. This caused incorrect token estimation via estimate_tokens() since it uses width * height / 750.
Use processed_image.dimensions() after all downscale passes so that ImageSize reflects the actual image sent to the provider.
Release Notes: