Keep trailing semicolons attached to the preceding word when wrapping#54546
Merged
eholk merged 1 commit intozed-industries:mainfrom Apr 22, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
cole-miller
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When soft-wrapping text,
LineWrapper::is_word_chardetermines which characters stick to the preceding word at wrap boundaries. The list already includes trailing punctuation like,,., and:, but was missing;. As a result, a message like "we won't pass it on; no big deal" could wrap with;isolated at the start of the next line (on/; no).This was most visible in the agent panel message editor but affects any surface that uses soft-wrapping.
Also adds
assert_word("on;")totest_is_word_charto guard against regressions.Release Notes:
;being wrapped to a new line instead of staying attached to the preceding word.