gpui: Fix follow_tail not re-engaging after scrollbar drag#54570
Merged
Anthony-Eid merged 5 commits intozed-industries:mainfrom Apr 23, 2026
Merged
Conversation
maxbrunsfeld
approved these changes
Apr 23, 2026
Anthony-Eid
approved these changes
Apr 23, 2026
AzureZee
added a commit
to AzureZee/gpuix
that referenced
this pull request
Apr 24, 2026
AzureZee
added a commit
to AzureZee/gpuix
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency with the way scrolling interacts with the
follow_tailGPUI list feature:follow_statetoFollowState::Tail { is_following: false }, so later scrolling to the bottom re-engagesfollow_tailfollow_statetoFollowState::Normal, preventingfollow_tailfrom re-engaging after scrolling to the bottomAs far as I can tell this behavior was unintentional, despite there being a test that exercised this exact behavior that
follow_taildoesn't re-engage after dragging the scrollbar — my best guess is that that test was derived from the bugged scrollbar handler logic, and not based on any actual intent for scrollbar drags to preventfollow_tailfrom re-engaging.Self-Review Checklist:
Release Notes: