Skip to content

gpui: Fix follow_tail not re-engaging after scrollbar drag#54570

Merged
Anthony-Eid merged 5 commits intozed-industries:mainfrom
timvermeulen:fix-follow-tail-after-scrollbar-drag
Apr 23, 2026
Merged

gpui: Fix follow_tail not re-engaging after scrollbar drag#54570
Anthony-Eid merged 5 commits intozed-industries:mainfrom
timvermeulen:fix-follow-tail-after-scrollbar-drag

Conversation

@timvermeulen
Copy link
Copy Markdown
Contributor

Fixes an inconsistency with the way scrolling interacts with the follow_tail GPUI list feature:

  • Scrolling normally sets follow_state to FollowState::Tail { is_following: false }, so later scrolling to the bottom re-engages follow_tail
  • Scrolling by dragging the scrollbar previously set follow_state to FollowState::Normal, preventing follow_tail from re-engaging after scrolling to the bottom

As far as I can tell this behavior was unintentional, despite there being a test that exercised this exact behavior that follow_tail doesn't re-engage after dragging the scrollbar — my best guess is that that test was derived from the bugged scrollbar handler logic, and not based on any actual intent for scrollbar drags to prevent follow_tail from re-engaging.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed agent panel auto-scroll not re-engaging after interacting with the scrollbar

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 22, 2026
@github-actions github-actions Bot added the community champion Issues filed by our amazing community champions! 🫶 label Apr 22, 2026
@Anthony-Eid Anthony-Eid added this pull request to the merge queue Apr 23, 2026
Merged via the queue into zed-industries:main with commit 2f445d4 Apr 23, 2026
31 checks passed
@timvermeulen timvermeulen deleted the fix-follow-tail-after-scrollbar-drag branch April 23, 2026 19:59
AzureZee added a commit to AzureZee/gpuix that referenced this pull request Apr 24, 2026
AzureZee added a commit to AzureZee/gpuix that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants