markdown: Make highlighting of rendered markdown more accurate#54744
Merged
NeelChotai merged 4 commits intozed-industries:mainfrom Apr 24, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
github-actions
Bot
added
the
community champion
Member
|
this is fantastic - I've noticed it personally, thank you for fixing! |
NeelChotai
approved these changes
Apr 24, 2026
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…ndustries#54744) Paints selections and search highlights of rendered markdown more accurately, to properly match what's actually being selected. Particularly noticeable when the selection spans multiple rows in a table cell or when it starts right after a soft wrap. |Before|After| | --- | --- | |<img width="831" height="677" alt="before" src="https://github.com/user-attachments/assets/3b2c33be-e4cb-400f-9ba6-4163eb438f99" /> | <img width="831" height="677" alt="after" src="https://github.com/user-attachments/assets/04161dd8-7f4a-46c5-8c63-3497d3533f6d" /> | Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed selection and search highlights in rendered markdown not always being displayed accurately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paints selections and search highlights of rendered markdown more accurately, to properly match what's actually being selected.
Particularly noticeable when the selection spans multiple rows in a table cell or when it starts right after a soft wrap.
Self-Review Checklist:
Release Notes: