Skip to content

Exit early on mutating actions in readonly editor#54758

Merged
SomeoneToIgnore merged 1 commit intomainfrom
kb/fix-readonly-mutating-actions
Apr 24, 2026
Merged

Exit early on mutating actions in readonly editor#54758
SomeoneToIgnore merged 1 commit intomainfrom
kb/fix-readonly-mutating-actions

Conversation

@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Apr 24, 2026

Hides and disables all mutating editor actions for readonly editors.

Certain actions (as cmd-backspace mentioned in the issue) could be somewhat beneficial to have for navigation purposes, but we'd better shape that story properly, let's build a "harness" and disable the mutating ones first.

Closes #47333

Release Notes:

  • Fixed readonly editor having certain mutation actions enabled

Also disable all related actions for readonly editors
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 24, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Apr 24, 2026
@SomeoneToIgnore SomeoneToIgnore requested a review from Veykril April 24, 2026 09:57
@SomeoneToIgnore SomeoneToIgnore added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 872faf0 Apr 24, 2026
42 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/fix-readonly-mutating-actions branch April 24, 2026 10:21
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
Hides and disables all mutating editor actions for readonly editors.

Certain actions (as cmd-backspace mentioned in the issue) could be
somewhat beneficial to have for navigation purposes, but we'd better
shape that story properly, let's build a "harness" and disable the
mutating ones first.

Closes zed-industries#47333

Release Notes:

- Fixed readonly editor having certain mutation actions enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd-backspace in read-only buffer highlights text

3 participants