Exit early on mutating actions in readonly editor#54758
Merged
SomeoneToIgnore merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
Also disable all related actions for readonly editors
Veykril
approved these changes
Apr 24, 2026
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
Hides and disables all mutating editor actions for readonly editors. Certain actions (as cmd-backspace mentioned in the issue) could be somewhat beneficial to have for navigation purposes, but we'd better shape that story properly, let's build a "harness" and disable the mutating ones first. Closes zed-industries#47333 Release Notes: - Fixed readonly editor having certain mutation actions enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides and disables all mutating editor actions for readonly editors.
Certain actions (as cmd-backspace mentioned in the issue) could be somewhat beneficial to have for navigation purposes, but we'd better shape that story properly, let's build a "harness" and disable the mutating ones first.
Closes #47333
Release Notes: