Fix ESLint not starting on Windows#54945
Merged
Veykril merged 1 commit intozed-industries:mainfrom Apr 27, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @tristanphease on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
Member
|
Nice @tristanphease! There are other reasons why ESLint could fail on Windows, too. See this: #54093 (comment). Once you fix this, I think users will hit the bug in my comment, based on other issues I’ve seen in the past, for example: #50677. |
Contributor
Author
|
I didn't see any bugs like that causing any issues, and I think the "os error 123" people are seeing (including me) is this one specifically. |
Contributor
Author
|
Hey @Veykril could you rerun that test please? Don't think it's related to the change |
Merged
via the queue into
zed-industries:main
with commit Apr 27, 2026
eced4ea
61 of 63 checks passed
tomhoule
pushed a commit
that referenced
this pull request
Apr 27, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #54093 (at least the os error 123 in the comments of that bug)/#54901 (although the diagnosis in that bug is totally wrong) Used process monitor to work out what that issue was: <img width="1573" height="94" alt="image" src="https://github.com/user-attachments/assets/2f82ad1a-8532-465d-9dcd-ba0bd092e9e7" /> There's actually a '\n' after node_modules there so it's an invalid directory. Add trim() to fix. After adding that change locally, eslint loaded fine Release Notes: - Fixed bug where eslint didn't start on Windows
|
Hello, I’d really like to see this bug fixed in the stable release. Could you cherry-pick this fix into the stable branch? |
Contributor
Author
|
@BlueBlue21 it's in preview. Think it should be released on the 6th (Wednesday) |
|
Thank you for your reply. |
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#54093 (at least the os error 123 in the comments of that bug)/zed-industries#54901 (although the diagnosis in that bug is totally wrong) Used process monitor to work out what that issue was: <img width="1573" height="94" alt="image" src="https://github.com/user-attachments/assets/2f82ad1a-8532-465d-9dcd-ba0bd092e9e7" /> There's actually a '\n' after node_modules there so it's an invalid directory. Add trim() to fix. After adding that change locally, eslint loaded fine Release Notes: - Fixed bug where eslint didn't start on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Closes #54093 (at least the os error 123 in the comments of that bug)/#54901 (although the diagnosis in that bug is totally wrong)
Used process monitor to work out what that issue was:
There's actually a '\n' after node_modules there so it's an invalid directory. Add trim() to fix.
After adding that change locally, eslint loaded fine
Release Notes: