Improve default interpreter path suggestion in quickpick UI #16971

Activity

1. Karthik Nadig (karthiknadig)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   needs PR

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   area-environmentsFeatures relating to handling interpreter environmentsFeatures relating to handling interpreter environments

   on Aug 13, 2021
2. Karthik Nadig (karthiknadig)

   added this to the August 2021 milestone on Aug 13, 2021
3. Karthik Nadig (karthiknadig)

   self-assigned this

   on Aug 13, 2021
4. Karthik Nadig (karthiknadig)

   removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Aug 13, 2021
5. Karthik Nadig (karthiknadig)

   closed this as completedin #16972on Aug 18, 2021
6. Karthik Nadig (karthiknadig)

   added

   verification-steps-neededSteps to verify are needed for verificationSteps to verify are needed for verification

   on Aug 19, 2021
7. Karthik Nadig (karthiknadig)

   assigned

   Kim-Adeline Miguel (kimadeline)

   on Aug 19, 2021
8. Karthik Nadig (karthiknadig)

   added

   verification-neededVerification of issue is requestedVerification of issue is requested

   on Aug 20, 2021
9. Karthik Nadig (karthiknadig)

   assigned

   Kim-Adeline Miguel (kimadeline)

   and unassigned

   Karthik Nadig (karthiknadig)

   and

   Kim-Adeline Miguel (kimadeline)

   on Aug 20, 2021
10. kimadeline commented on Aug 20, 2021

    

    Kim-Adeline Miguel (kimadeline)

    on Aug 20, 2021

    Last edited by kimadeline

    More actions

    ### Verification steps:

    1. Make sure you have "python.experiments.optInto": ["All"], in your user settings. If not, add it and reload.
    2. Create 2 workspaces with Python files in it, and create a virtual environment in one of them (python -m venv .venv). Let's name them with and without

    #### 1. python .defaultInterpreterPath not set, no virtual environment

    1. Make sure that the python.defaultIntepreterPath entries in your user and workspace settings are at their default value python
    2. Open the without workspace, wait for the extension to load, and click on the interpreter in the status bar on the bottom left:
    
    3. Make sure that the interpreter that is currently highlighted in the quickpick is the same as the one that is currently selected (same path being shown in Current: ....), that the entry label starts with star ⭐️ , and that its description says "Recommended"
    4. Make sure that there is no "Use Python from python.defaultInterpreterPath setting" entry

    #### 2. python.defaultInterpreterPath set, no virtual environment

    1. Set one of the python.defaultIntepreterPath entries in your user and workspace settings to a valid Python interpreter path that is not python (for example /usr/local/bin/python3)
    2. Open the without workspace, wait for the extension to load, and click on the interpreter in the status bar on the bottom left
    2. Make sure that the interpreter currently selected has the same path as what's in python.defaultInterpreterPath
    2. Make sure there is a "Use Python from python.defaultInterpreterPath setting" entry with the same path, that this entry is highlighted, and that it's the second on the list starting from the top (right below "Enter interpreter path...")

    #### 3. python.defaultInterpreterPath not set, with virtual environment

    1. Make sure the python.defaultIntepreterPath entry in your user and workspace settings are at their default value python
    2. Open the with workspace, wait for the extension to load
    3. Make sure that the interpreter in the status bar on the bottom left is the .venv virtual environment you created above, and then click it
    3. Make sure that the interpreter that is currently highlighted in the quickpick is the .venv one, that the entry should be the second one from the top, that its label starts with a star ⭐️, and that its description says "Recommended"
    3. Make sure that there are no duplicate entries with the same interpreter path
    4. Make sure that there is no "Use Python from python.defaultInterpreterPath setting" entry

    #### 4. python.defaultInterpreterPath set, with virtual environment

    1. Set one of the python.defaultIntepreterPath entries in your user and workspace settings to a valid Python interpreter path that is not python (for example /usr/local/bin/python3)
    2. Open the with workspace, wait for the extension to load, and click on the interpreter in the status bar on the bottom left
    2. Make sure that the interpreter currently selected has the same path as what's in python.defaultInterpreterPath
    2. Make sure there is a "Use Python from python.defaultInterpreterPath setting" entry with the same path, that this entry is highlighted, and that it's the second on the list starting from the top (right below "Enter interpreter path...")
    3. Make sure that the third entry is the .venv environment, that its label starts with a star ⭐️, and that its description says "Recommended"
11. Kim-Adeline Miguel (kimadeline)

    removed

    verification-steps-neededSteps to verify are needed for verificationSteps to verify are needed for verification

    on Aug 20, 2021
12. karthiknadig commented on Aug 20, 2021

    

    Karthik Nadig (karthiknadig)

    on Aug 20, 2021

    Last edited by karthiknadig

    MemberAuthor

    More actions

    Kim-Adeline Miguel (@kimadeline) This looks like it has enough steps to be a test plan item on its own. I had to turn one of mine to test-plan item as well.
13. kimadeline commented on Aug 20, 2021

    

    Kim-Adeline Miguel (kimadeline)

    on Aug 20, 2021

    More actions

    Sounds good, I'll move it to a test plan. Thanks!
14. Kim-Adeline Miguel (kimadeline)

    added

    on-testplanAdded to test planAdded to test plan

    and removed

    verification-neededVerification of issue is requestedVerification of issue is requested

    on Aug 23, 2021
15. Kim-Adeline Miguel (kimadeline)

    removed their assignment

    on Aug 23, 2021
16. github-actions

    locked as resolved and limited conversation to collaborators on Sep 23, 2021