Repository navigation
Support for newline and encoding in tempfile module #45374
Description
| BPO | 1033 |
|---|---|
| Nosy | @gvanrossum |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2007-08-28.03:30:24.434>
created_at = <Date 2007-08-27.00:10:44.421>
labels = ['type-feature', 'library']
title = 'Support for newline and encoding in tempfile module'
updated_at = <Date 2007-08-28.03:30:24.379>
user = 'https://bugs.python.org/hupp'bugs.python.org fields:
activity = <Date 2007-08-28.03:30:24.379>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2007-08-28.03:30:24.434>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2007-08-27.00:10:44.421>
creator = 'hupp'
dependencies = []
files = ['8331']
hgrepos = []
issue_num = 1033
keywords = []
message_count = 3.0
messages = ['55328', '55329', '55349']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'hupp']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1033'
versions = ['Python 3.0']
Activity
hupp commentedon Aug 27, 2007
It would be useful for tempfile.TemporaryFile and friends to pass
newline and encoding arguments to the underlying io.open call. For
example, several tests in test_csv use TemporaryFile and need to handle
unicode file output or preserve exact newlines. This is simpler with
direct support in TemporaryFile.
The attached patch makes the following changes:
now pass newline and encoding to the underlying io.open call.
hupp commentedon Aug 27, 2007
One change I forgot to mention that may need discussion. I've changed
the 'bufsize' arguments in tempfile to 'buffering', since that is
consistent with the same change in os.fdopen.
gvanrossum commentedon Aug 28, 2007
Thanks!
Committed revision 57594.
General note: please run Tools/scripts/reindent.py over your files after
editing so I won't have to.