Repository navigation
Fix duplicate entries being created when the unique field is the slug - #151
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where re-running an import with "Update existing items" enabled and
slugas the unique field would create duplicate entries instead of updating the existing ones.This was happening because Statamic slugifies an entry's slug when it's saved (so
Hello Worldis stored ashello-world), but the importer was looking up existing entries using the raw value from the import file, which never matched.This PR fixes it by slugifying the value before querying for an existing entry when the unique field is the slug, using the site's language so it matches what Statamic stores.
Fixes #150