Add bpfel/bpfeb CPU constraint values#131
Closed
tamird wants to merge 1 commit intobazelbuild:mainfrom
Closed
Conversation
These names are used in clang (see https://github.com/llvm/llvm-project/blob/6bee6b2/llvm/include/llvm/TargetParser/Triple.h#L1154-L1157) and Rust (see https://github.com/rust-lang/rust/blob/f5e2df7/src/doc/rustc/src/platform-support.md?plain=1#L311-L312). This addition is a prerequisite for teaching `rules_rust` about these constraints.
Author
|
@gregestren could you please have a look at this and #123? The motivation between these two is very similar, and I'd like to follow @avrabe's lead on the proper way to plumb things in |
UebelAndre
pushed a commit
to UebelAndre/rules_rust
that referenced
this pull request
May 1, 2026
Add support for tier 3 targets bpfeb-unknown-none and bpfel-unknown-none (see https://github.com/rust-lang/rust/blob/f5e2df7/src/doc/rustc/src/platform-support.md?plain=1#L311-L312). This is modeled after bazelbuild#3507 and should probably be updated if/when bazelbuild/platforms#131 is merged. (please use rebase merge when landing this as the proper commit message is in the commit, rather than the PR description) /cc @avrabe
dzbarsky
pushed a commit
to hermeticbuild/rules_rust
that referenced
this pull request
May 3, 2026
Add support for tier 3 targets bpfeb-unknown-none and bpfel-unknown-none (see https://github.com/rust-lang/rust/blob/f5e2df7/src/doc/rustc/src/platform-support.md?plain=1#L311-L312). This is modeled after bazelbuild#3507 and should probably be updated if/when bazelbuild/platforms#131 is merged. (please use rebase merge when landing this as the proper commit message is in the commit, rather than the PR description) /cc @avrabe
dzbarsky
pushed a commit
to hermeticbuild/rules_rust
that referenced
this pull request
May 5, 2026
Add support for tier 3 targets bpfeb-unknown-none and bpfel-unknown-none (see https://github.com/rust-lang/rust/blob/f5e2df7/src/doc/rustc/src/platform-support.md?plain=1#L311-L312). This is modeled after bazelbuild#3507 and should probably be updated if/when bazelbuild/platforms#131 is merged. (please use rebase merge when landing this as the proper commit message is in the commit, rather than the PR description) /cc @avrabe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These names are used in clang (see
https://github.com/llvm/llvm-project/blob/6bee6b2/llvm/include/llvm/TargetParser/Triple.h#L1154-L1157)
and Rust (see
https://github.com/rust-lang/rust/blob/f5e2df7/src/doc/rustc/src/platform-support.md?plain=1#L311-L312).
This addition is a prerequisite for teaching
rules_rustabout theseconstraints.
This is an alternative to #99 which
spelled these names incorrectly.
Closes #99.