Fix code coverage collection.#2001
Merged
UebelAndre merged 4 commits intobazelbuild:mainfrom Jun 13, 2023
Merged
Conversation
e9ca5ed to
31c0896
Compare
e456134 to
d15d2f2
Compare
Collaborator
Author
|
I'm seeing an odd failure on RBE builds. @scentini @meteorcloudy would either of you be able to take a look? |
Member
|
/cc @coeuvre any idea? |
5723f6e to
db08b06
Compare
aed87d0 to
8da20e8
Compare
Merged
Collaborator
Author
|
I've deferred the issue mentioned on #2001 (comment) to #2005 |
Collaborator
Author
|
Adding @krasimirgg and @scentini to see if I can't get this merged soon for the release 😅 |
Collaborator
Author
|
I made #2004 as a minor spinoff so there's a unique commit for the change. |
illicitonion
approved these changes
Jun 13, 2023
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
* Minor CI and test cleanup * Bump min tested Bazel version to 5.2.0 * Fix code coverage collection.
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
* Minor CI and test cleanup * Bump min tested Bazel version to 5.2.0 * Fix code coverage collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes code coverage. Some notable findings as of Bazel 6.2.1.
_collect_cc_coverageand_lcov_mergerare magic attributes that enable the coverage behavior folks might be familiar with in C++ and other native rules.COVERAGE_OUTPUT_FILEin_collect_cc_coveragetools. This value appears to only be intended for_lcov_mergertools. Instead, write toCOVERAGE_DIR..datextension.Additionally this bumps the min tested version to avoid the following error: