Allow the customization of sysroot_src in the generated rust-project.…#3306
Merged
illicitonion merged 6 commits intobazelbuild:mainfrom Jun 22, 2025
Merged
Conversation
…json When specifying a local rust toolchain with an unconventional rust-src location; this attribute will allow you to influence what the sysroot_src path in the resulting rust-project.json.
photex
force-pushed
the
dev/chip/rust_analyzer_toolchain-rustc_srcs_path
branch
from
208efe1 to
4385abe
Compare
illicitonion
approved these changes
May 1, 2025
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Sorry for the huge delay here! This looks reasonable to me - do these simplifying suggestions make sense to you?
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Contributor
Author
|
Thank you for the review and suggested improvements @illicitonion. :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying a local rust toolchain with an unconventional rust-src location; this attribute will allow you to influence what the sysroot_src path in the resulting rust-project.json.
In my particular case I'm working in a conda environment which I configure as a new_local_repo in my project.
There I define a rust toolchain and my rustc sources live in
$CONDA_PREFIX/lib/rustlib/src/rust/library. By default, if I'm unable to provide this path, the resulting sysroot_src in my project ends up resolving to the equivalent of$CONDA_PREFIX/library.