Allow renaming generated Prost crate name#3438
Merged
illicitonion merged 2 commits intobazelbuild:mainfrom Jun 22, 2025
Merged
Conversation
## What? Adds `crate_name` to `rust_prost_transform` which allows overriding the generated crate name ## Why? This allows the end user to control the name of the generated crates to avoid conflicts. Closes Prost Crate Naming Conventions bazelbuild#2889
illicitonion
approved these changes
Jun 22, 2025
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Seems reasonable! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds
crate_nametorust_prost_transformwhich allows overriding the generated crate nameWhy?
This allows the end user to control the name of the generated crates to avoid conflicts.
Closes Prost Crate Naming Conventions #2889