Build and upload s390x-unknown-linux-gnu crate_universe binary to releases#3462
Merged
UebelAndre merged 1 commit intobazelbuild:mainfrom Aug 28, 2025
Merged
Conversation
Contributor
Author
|
Gentle ping. Anyone have time to look at this PR? |
Collaborator
|
Needs a rebase though |
f216763 to
2a02b35
Compare
Contributor
Author
|
Thanks for looking at this @UebelAndre. I have rebased it. |
2a02b35 to
8dda352
Compare
Contributor
Author
|
Hi @UebelAndre, I have rebased this PR again. Would it be possible to merge it after the checks have completed? |
Contributor
Author
|
Thanks for reviewing and merging @UebelAndre! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building envoy on s390x, I get an error when trying to download the cargo-bazel binary because it is not published to github releases (see example message below).
This PR adds s390x-unknown-linux-gnu to the list of targets to release.
Error message: