Allow setting timeout for cargo-bazel.#3485
Merged
illicitonion merged 6 commits intobazelbuild:mainfrom Aug 2, 2025
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sardok
force-pushed
the
cargo-bazel-timeout
branch
from
3114fa6 to
89e8296
Compare
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Please can you add the env var to
as well to make sure we'll invalidate and re-run the repository rules if the env var changes?Thanks!
Contributor
Author
|
Thanks @illicitonion for the review. I added the change you asked. Also updated the rule & extension docs about it (although i'm not sure if it is right thing to do because |
wmeddie
added a commit
to XpressAI/xpressclaw
that referenced
this pull request
Mar 27, 2026
rules_rust 0.61.0 hardcodes the cargo-bazel splice timeout at 600s with no override. The CARGO_BAZEL_GENERATOR_TIMEOUT env var we were setting does not exist. rules_rust 0.64.0 added CARGO_BAZEL_TIMEOUT (PR bazelbuild/rules_rust#3485). Updated MODULE.bazel, build.ps1, and release.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
CARGO_BAZEL_TIMEOUTenv variable to set timeout value forcargo-bazelinvocation.