Fix panic line numbers#3492
Merged
illicitonion merged 8 commits intobazelbuild:mainfrom Jul 20, 2025
Merged
Conversation
Without this patch, line numbers are missing for first-party code in panic traces. This reverts part of bazelbuild#1563 but keeps the test showing we have a relative path not an absolute one, and adds an integration test showing that line numbers are correctly reported in panic traces. As far as I know, path remapping has been improved in rustc over the last few years, so maybe the behaviour reported in that patch has been fixed.
illicitonion
force-pushed
the
fix-remapping
branch
from
df4d02c to
3074ed3
Compare
scentini
approved these changes
Jul 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
I think this needs to be rebased and merged again. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, line numbers are missing for first-party code in panic traces.
This reverts part of #1563 but keeps the test showing we have a relative path not an absolute one, and adds an integration test showing that line numbers are correctly reported in panic traces.
As far as I know, path remapping has been improved in rustc over the last few years, so maybe the behaviour reported in that patch has been fixed.
Closes #3476