Add buildifier hook#3529
Conversation
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! I think adding a pre-commit hook is fine but I don't think we should disable the CI check otherwise folks thinks could be missed by folks who didn't run the pre-commit hook. Can you re-enable that in this change?
Buildifier is still running in CI as part of pre-commit. If you scroll down to the end of the CI job you can see the pre-commit run --all-files. This will make sure that all formatters we maintain in pre-commit are also executed in CI. If you look at the CI logs of this branch, you can see that buildifier is still executed. |
|
@UebelAndre PTAL |
Replace the buildifier CI call with the pre-commit hook. Now developers can run exactly the same formatting and linting as we use in CI