Skip to content

[cargo-bazel] Avoid regenerating cargo lockfile when splicing is not needed#3593

Merged
illicitonion merged 1 commit intobazelbuild:mainfrom
hermeticbuild:zbarsky/lockfile-overwrite
Sep 27, 2025
Merged

[cargo-bazel] Avoid regenerating cargo lockfile when splicing is not needed#3593
illicitonion merged 1 commit intobazelbuild:mainfrom
hermeticbuild:zbarsky/lockfile-overwrite

Conversation

@dzbarsky
Copy link
Copy Markdown
Contributor

@dzbarsky dzbarsky commented Sep 4, 2025

If we already have a Cargo.lock and don't intend to let cargo-bazel update it, we can just use it for splicing directly.

@dzbarsky dzbarsky force-pushed the zbarsky/lockfile-overwrite branch from 1ce428e to 7e615e5 Compare September 5, 2025 12:42
@dzbarsky dzbarsky force-pushed the zbarsky/lockfile-overwrite branch from 7e615e5 to b265c47 Compare September 8, 2025 13:03
@dzbarsky dzbarsky changed the title [cargo-bazel] Avoid regenerating cargo lockfile when splicing if not needed [cargo-bazel] Avoid regenerating cargo lockfile when splicing is not needed Sep 8, 2025
Copy link
Copy Markdown
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@illicitonion illicitonion added this pull request to the merge queue Sep 27, 2025
Merged via the queue into bazelbuild:main with commit d0167cf Sep 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants