Add gcc-ld to rustc_lib target#3600
Merged
UebelAndre merged 1 commit intobazelbuild:mainfrom Sep 11, 2025
Merged
Conversation
Contributor
Author
|
@UebelAndre is this something you can review? |
UebelAndre
requested changes
Sep 11, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
This seems fine to me but how exactly does this ensure these targets will be used? Shouldn't this be something explicitly tracked by the toolchain and passed in Rustc actions?
Contributor
Author
|
@UebelAndre This PR doesn't ensure they'll be used, merely that it becomes possible to use them. It's still useful because folks who want to enable gcc-ld in their own setup can now do so with a configuration. |
UebelAndre
approved these changes
Sep 11, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
--codegen=link-arg=-B$(RUST_SYSROOT)/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld
This is a bit cryptic but the change alone is fine. I still think this is something that should be made default and put behind an incompatibility flag. Thanks for including these files though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to use the self-contained
rust-lldlinker through the gcc driver, which will be the default setup in Rust 1.90.0.