Ensure the library search path from cc_toolchain is preferred over whatever rustc finds in the Windows registry#3608
Merged
illicitonion merged 2 commits intobazelbuild:mainfrom Sep 29, 2025
Conversation
illicitonion
approved these changes
Sep 27, 2025
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Seems reasonable! Thanks!
… is preferred over whatever rustc finds in the Windows registry.
dgrunwald-qt
force-pushed
the
fix-3256
branch
from
35e1db2 to
5743087
Compare
Contributor
Author
|
Oops, I forgot to set up the pre-commit hooks. Formatting is fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see a good way to stop rustc from adding the non-hermetic library search path, so put our cc_toolchain library search path on the command line where it has precedence over the non-hermetic path injected by rustc.
See https://rust-lang.zulipchat.com/#narrow/channel/242869-t-compiler.2Fwindows/topic/rust.20LIB.20path for discussion of the rustc behavior.
Closes #3256.