Allow passing env files to build script runtime env#3632
Allow passing env files to build script runtime env#3632UebelAndre merged 1 commit intobazelbuild:mainfrom
Conversation
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Can you add a regression test for this?
15e0069 to
ebc8afe
Compare
Yeah, I wasn't sure the best way to test this. Ideally we would have some e2e cargo_universe tests but I didn't see them (maybe I missed them)? I can add a unit test for this attribute though, it would be better than nothing |
3d551d1 to
d3cff53
Compare
Well the straight forward one is the change to |
d3cff53 to
7dc0363
Compare
Yep that's what I ended up implementing, PTAL :) |
Fixes #3625, see that issue for explanation