collect_inputs.files: fix docs and and add a check for data#3657
Merged
krasimirgg merged 1 commit intobazelbuild:mainfrom Oct 6, 2025
Merged
collect_inputs.files: fix docs and and add a check for data#3657krasimirgg merged 1 commit intobazelbuild:mainfrom
data#3657krasimirgg merged 1 commit intobazelbuild:mainfrom
Conversation
…re accessing data
UebelAndre
approved these changes
Oct 6, 2025
dzbarsky
reviewed
Oct 6, 2025
| # The old default behavior was to include data files at compile time. | ||
| # This flag controls whether to include data files in compile_data. | ||
| if not toolchain._incompatible_do_not_include_data_in_compile_data: | ||
| if hasattr(files, "data") and not toolchain._incompatible_do_not_include_data_in_compile_data: |
Contributor
There was a problem hiding this comment.
please flip to if not toolchain._incompatible_do_not_include_data_in_compile_data and hasattr(files, "data"): to avoid adding additional checks for most users (it defaults to True)
Collaborator
Author
There was a problem hiding this comment.
sorry, submitted too fast, doing as a follow-up...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes intended.