Bump ctve's autocfg from 1.4.0 -> 1.5.0 to pick up determinism fix.#3669
Merged
UebelAndre merged 3 commits intobazelbuild:mainfrom Oct 16, 2025
Merged
Bump ctve's autocfg from 1.4.0 -> 1.5.0 to pick up determinism fix.#3669UebelAndre merged 3 commits intobazelbuild:mainfrom
UebelAndre merged 3 commits intobazelbuild:mainfrom
Conversation
UebelAndre
requested changes
Oct 15, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Instead if adding this dependency can you just run
bazel run //cargo/cargo_toml_variable_extractor/3rdparty:crates_vendor -- --repin=autocfg
and commit the results?
Contributor
Author
Yeah I can, it works, thanks! A bit of noise with the addition of |
UebelAndre
approved these changes
Oct 16, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some action determinism analysis and found that rules_rust's ctve's autocfg (version 1.4.0) showed up in a lot of sha differences.... looks like it leaves behind files with random filenames. This was fixed upstream in cuviper/autocfg#75, which is included in autocfg 1.5.0.
Posted about this in slack at https://bazelbuild.slack.com/archives/CSV56UT0F/p1760515874096159.