use an empty staticlib as an allocator library for cc_common.link#3864
Merged
krasimirgg merged 4 commits intobazelbuild:mainfrom Feb 23, 2026
Merged
use an empty staticlib as an allocator library for cc_common.link#3864krasimirgg merged 4 commits intobazelbuild:mainfrom
krasimirgg merged 4 commits intobazelbuild:mainfrom
Conversation
krasimirgg
changed the title
UebelAndre
approved these changes
Feb 23, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Sounds good to me, thank you!
dzbarsky
reviewed
Feb 23, 2026
| providers = _rust_static_library_impl(ctx) | ||
| return providers + [_RustBuiltWithoutProcessWrapperInfo()] | ||
|
|
||
| rust_static_library_without_process_wrapper = rule( |
This was referenced Feb 25, 2026
Contributor
|
Since this now works on stable, could it be enabled by default? It seems like doing so would allow us to remove the cc versions of the allocator libraries. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
`rust_static_library` targets fail for wasm-style platform mappings whose `staticlib_ext` is empty. This became visible after #3864 changed the allocator shim target to use `rust_static_library`. When building that target for the wasm platform, rules_rust computes: ``` crate_type = "staticlib" staticlib_ext = "" ``` `determine_lib_name` treats the empty extension as invalid and fails with: ``` Unknown crate_type: staticlib ``` Static library outputs for these wasm/WASI-style targets should use archive output names, e.g. libfoo.a. Binary and dylib outputs can continue using .wasm. This updates the wasm-style staticlib mappings to .a for: - threads - unknown - wasi - wasip1 - wasip2 This is easily reproducible from the rules_rust repository, before this change: ``` bazel build --platforms=//rust/platform:wasm32 //ffi/rs/allocator_library:allocator_library ``` fails during analysis with: ``` Unknown crate_type: staticlib ``` closes #3894
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes intended.
As suggested on multiple channels, using an empty staticlib is a good effective way to ensure we get the rust allocator shims generated consistently. This is simpler than what we have and also looks like it uniformly supports stable and nightly across versions.
closes #3459