-
Notifications
You must be signed in to change notification settings - Fork 37.4k
#196344 - Fix installer hang issue #228233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixes #196344 @CyMad7001, thank you! Here's some swag for you: https://swag.code.visualstudio.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an installer hang issue (#196344) by adding PowerShell execution parameters to prevent profile loading and interactive prompts during the tunnel service termination process.
Key Changes:
- Added
-NoLogo -NoProfile -NonInteractive -WindowStyle Hidden -ExecutionPolicy Bypassparameters to the PowerShell invocation inStopTunnelOtherProcesses()function - Aligns this PowerShell invocation with the pattern already established elsewhere in the installer script
deepak1556
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fixes #196344 related to #228233 Co-authored-by: CyMad <[email protected]>
|
Closing in favor of #282201, due to new policy regarding the |
Pull request was closed
* fix: frozen windows installations fixes #196344 related to #228233 Co-authored-by: CyMad <[email protected]> * Update build/win32/code.iss Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: CyMad <[email protected]> Co-authored-by: Copilot <[email protected]>
Fix issue with installer hanging on some installations #196344.
Cause
Maybe to do with blocking in some users profiles. The installer executes a number of powershell commands during installation all of which load the users profile. These profiles may be blocking the installer from executing if there is user input required. Simply executing with the "-NoProfile " parameter should resolve the issue.
Resolution
Include "-NoProfile " when executing powershell scripts/commands during the installation process