Skip to content

Add Owned::into_raw to relinquish ownership of an handle#3869

Merged
kennykerr merged 5 commits intomicrosoft:masterfrom
sylveon:master
Feb 4, 2026
Merged

Add Owned::into_raw to relinquish ownership of an handle#3869
kennykerr merged 5 commits intomicrosoft:masterfrom
sylveon:master

Conversation

@sylveon
Copy link
Copy Markdown
Collaborator

@sylveon sylveon commented Feb 2, 2026

This API mirrors Box::into_raw but operates on Windows handles

Add basic unit tests for Owned

Fixes #3857

This API mirrors Box::into_raw but operates on Windows handles

Add basic unit tests for Owned

Fixes #3857
Comment thread crates/libs/core/src/handles.rs Outdated
@riverar riverar requested a review from kennykerr February 2, 2026 03:55
Comment thread crates/libs/core/src/handles.rs Outdated
@riverar
Copy link
Copy Markdown
Collaborator

riverar commented Feb 2, 2026

After scratching my head, I took a peek at GitHub Status and looks like Actions is broken right now. https://www.githubstatus.com/ Standby.

@kennykerr
Copy link
Copy Markdown
Collaborator

cargo fmt should fix the build break.

@sylveon
Copy link
Copy Markdown
Collaborator Author

sylveon commented Feb 4, 2026

Formatted

Copy link
Copy Markdown
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@kennykerr kennykerr merged commit a1db204 into microsoft:master Feb 4, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Owned should have a way to relinquish ownership

3 participants