Remove Drop impl on VARIANT and PROPVARIANT#3886
Merged
Conversation
Collaborator
Author
|
I considered special-casing the |
Collaborator
Author
|
Manually verified #3818 continues to crash ( |
kennykerr
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VARIANTandPROPVARIANTpreviously implementedDropby unconditionally callingVariantClear/PropVariantClear. This created a problem as ownership of these types is context-dependent. In particular, some implementations of COM interfaces (e.g.,IUIAutomationPropertyChangedEventHandler) receive [in] VARIANT parameters they do not own, and the implicitDropwould free memory still owned by the caller, causing double-frees and spurious Release calls on embedded values.These types now implement
Freeinstead, consistent with other Win32 types whose cleanup is context-dependent. Callers that require automatic cleanup should wrap values inOwned<T>:Fixes #3818