module: add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX #56610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
errors
jasnell
approved these changes
Jan 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
idk why the coverage complains, the behavioral change is tested 😫 |
BridgeAR
approved these changes
Jan 15, 2025
marco-ippolito
added
author ready
Member
Author
|
Removed some dead code. Since we splitted compilation from execution, there is no need to check if what is thrown is not an error or if error properties have been overwritten. |
marco-ippolito
force-pushed
the
update-error-to-syntax-error
branch
from
f300ebb to
f67762a
Compare
GeoffreyBooth
approved these changes
Jan 15, 2025
Co-authored-by: Geoffrey Booth <[email protected]>
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Ethan-Arrowood
approved these changes
Jan 15, 2025
marco-ippolito
added
commit-queue
aduh95
reviewed
Jan 15, 2025
aduh95
added
semver-minor
aduh95
reviewed
Jan 15, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
marco-ippolito
force-pushed
the
update-error-to-syntax-error
branch
from
a3e87d4 to
b15ee51
Compare
Collaborator
legendecas
approved these changes
Jan 16, 2025
robpalme
approved these changes
Jan 16, 2025
Comment on lines
+3148
to
+3150
| The provided TypeScript syntax is unsupported. | ||
| This could happen when using TypeScript syntax that requires | ||
| transformation with [type-stripping][]. |
Contributor
There was a problem hiding this comment.
Should we be more explicit and immediately suggest to the user that a potential solution is to run using --experimental-transform-types?
Member
There was a problem hiding this comment.
Seems like a more forward-looking suggestion would be to suggest they use the TS 5.8 option (once it's out) so they avoid using that syntax in the first place (or perhaps both suggestions)
Member
Author
There was a problem hiding this comment.
We could add it in the error message itself?
I will followup with a PR after swc updates since I have to refactor error messages anyways
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in cee63dc |
marco-ippolito
added
the
backport-open-v22.x
aduh95
added
backported-to-v22.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new error allows user to know if its unsupported syntax like enums in strip-types or just general invalid syntax.