[WPE] Web Inspector: implement platformSave

spenap · spenap · commit c6483e96e3ff · 2026-02-05T18:21:01.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=306768 Reviewed by Adrian Perez de Castro. Extracted a common GIO-based implementation for WebKitGTK and WPE WebKit into WebInspectorUIProxyGLib. For WebKitGTK, the logic keeps using file chooser dialog to get an appropriate destination filename. For WPE, this uses G_USER_DIRECTORY_DOWNLOAD and falls back to the user's home directory if undefined, saving the file there with the first 8 elements of the contents hash to avoid accidental overwrites. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/Inspector/glib/WebInspectorUIProxyGLib.cpp: Added. (WebKit::fileReplaceContentsCallback): (WebKit::platformSaveDataToFile): * Source/WebKit/UIProcess/Inspector/glib/WebInspectorUIProxyGLib.h: * Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp: (WebKit::WebInspectorUIProxy::platformSave): (WebKit::fileReplaceContentsCallback): Deleted. * Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp: (WebKit::computeContentHash): (WebKit::WebInspectorUIProxy::platformSave): * Source/WebKit/WebProcess/Inspector/wpe/WebInspectorUIWPE.cpp: (WebKit::WebInspectorUI::canSave): Canonical link: https://commits.webkit.org/306914@main
diff --git a/Source/WebKit/SourcesGTK.txt b/Source/WebKit/SourcesGTK.txt
@@ -245,6 +245,7 @@ UIProcess/geoclue/GeoclueGeolocationProvider.cpp
 
 UIProcess/Inspector/glib/RemoteInspectorClient.cpp
 UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp
+UIProcess/Inspector/glib/WebInspectorUIProxyGLib.cpp
 
 UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp
 UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp
diff --git a/Source/WebKit/SourcesWPE.txt b/Source/WebKit/SourcesWPE.txt
@@ -256,6 +256,7 @@ UIProcess/gstreamer/WebPageProxyGStreamer.cpp
 
 UIProcess/Inspector/glib/RemoteInspectorClient.cpp
 UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp
+UIProcess/Inspector/glib/WebInspectorUIProxyGLib.cpp
 
 UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp
 
diff --git a/Source/WebKit/UIProcess/Inspector/glib/WebInspectorUIProxyGLib.cpp b/Source/WebKit/UIProcess/Inspector/glib/WebInspectorUIProxyGLib.cpp
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2026 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "WebInspectorUIProxyGLib.h"
+
+#include <wtf/glib/GUniquePtr.h>
+#include <wtf/glib/WTFGType.h>
+#include <wtf/text/Base64.h>
+
+namespace WebKit {
+
+struct PlatformSaveData {
+    Vector<uint8_t> dataVector;
+    CString dataString;
+};
+WEBKIT_DEFINE_ASYNC_DATA_STRUCT(PlatformSaveData)
+
+using PlatformSaveDataPtr = std::unique_ptr<PlatformSaveData, decltype(&destroyPlatformSaveData)>;
+
+static void fileReplaceContentsCallback(GObject* sourceObject, GAsyncResult* result, gpointer userData)
+{
+    PlatformSaveDataPtr data(static_cast<PlatformSaveData*>(userData), destroyPlatformSaveData);
+    GFile* file = G_FILE(sourceObject);
+
+    WTF::GUniqueOutPtr<GError> error;
+    if (!g_file_replace_contents_finish(file, result, nullptr, &error.outPtr()))
+        LOG_ERROR("Error replacing contents to file %s: %s", g_file_get_path(file), error->message);
+}
+
+void platformSaveDataToFile(GRefPtr<GFile>&& file, const String& content, bool base64Encoded)
+{
+    PlatformSaveDataPtr platformSaveData(createPlatformSaveData(), destroyPlatformSaveData);
+
+    if (base64Encoded) {
+        auto decodedData = base64Decode(content);
+        if (!decodedData)
+            return;
+        decodedData->shrinkToFit();
+        platformSaveData->dataVector = WTF::move(*decodedData);
+    } else
+        platformSaveData->dataString = content.utf8();
+
+    const char* data = !platformSaveData->dataString.isNull() ? platformSaveData->dataString.data() : reinterpret_cast<const char*>(platformSaveData->dataVector.span().data());
+    size_t dataLength = !platformSaveData->dataString.isNull() ? platformSaveData->dataString.length() : platformSaveData->dataVector.size();
+
+    g_file_replace_contents_async(file.get(), data, dataLength, nullptr, false,
+        G_FILE_CREATE_NONE, nullptr, fileReplaceContentsCallback, platformSaveData.release());
+}
+
+} // namespace WebKit
diff --git a/Source/WebKit/UIProcess/Inspector/glib/WebInspectorUIProxyGLib.h b/Source/WebKit/UIProcess/Inspector/glib/WebInspectorUIProxyGLib.h
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2026 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#include <gio/gio.h>
+#include <wtf/Forward.h>
+#include <wtf/glib/GRefPtr.h>
+
+namespace WebKit {
+
+void platformSaveDataToFile(GRefPtr<GFile>&&, const String& content, bool base64Encoded);
+
+} // namespace WebKit
diff --git a/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp b/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp
@@ -40,6 +40,7 @@
 #include "WebFramePolicyListenerProxy.h"
 #include "WebInspectorUIMessages.h"
 #include "WebInspectorUIProxyClient.h"
+#include "WebInspectorUIProxyGLib.h"
 #include "WebKitInspectorWindow.h"
 #include "WebKitWebViewBasePrivate.h"
 #include "WebOpenPanelResultListenerProxy.h"
@@ -529,12 +530,6 @@ void WebInspectorUIProxy::platformStartWindowDrag()
     notImplemented();
 }
 
-static void fileReplaceContentsCallback(GObject* sourceObject, GAsyncResult* result, gpointer userData)
-{
-    GFile* file = G_FILE(sourceObject);
-    g_file_replace_contents_finish(file, result, nullptr, nullptr);
-}
-
 void WebInspectorUIProxy::platformSave(Vector<WebCore::InspectorFrontendClient::SaveData>&& saveDatas, bool forceSaveAs)
 {
     ASSERT(saveDatas.size() == 1);
@@ -562,23 +557,8 @@ void WebInspectorUIProxy::platformSave(Vector<WebCore::InspectorFrontendClient::
     if (gtk_native_dialog_run(GTK_NATIVE_DIALOG(dialog.get())) != GTK_RESPONSE_ACCEPT)
         return;
 
-    Vector<uint8_t> dataVector;
-    CString dataString;
-    if (saveDatas[0].base64Encoded) {
-        auto decodedData = base64Decode(saveDatas[0].content, { Base64DecodeOption::ValidatePadding });
-        if (!decodedData)
-            return;
-        decodedData->shrinkToFit();
-        dataVector = WTF::move(*decodedData);
-    } else
-        dataString = saveDatas[0].content.utf8();
-
-    const char* data = !dataString.isNull() ? dataString.data() : reinterpret_cast<const char*>(dataVector.span().data());
-    size_t dataLength = !dataString.isNull() ? dataString.length() : dataVector.size();
     GRefPtr<GFile> file = adoptGRef(gtk_file_chooser_get_file(chooser));
-    GUniquePtr<char> path(g_file_get_path(file.get()));
-    g_file_replace_contents_async(file.get(), data, dataLength, nullptr, false,
-        G_FILE_CREATE_REPLACE_DESTINATION, nullptr, fileReplaceContentsCallback, protect(inspectorPage()).get());
+    platformSaveDataToFile(WTF::move(file), saveDatas[0].content, saveDatas[0].base64Encoded);
 }
 
 void WebInspectorUIProxy::platformLoad(const String&, CompletionHandler<void(const String&)>&& completionHandler)
diff --git a/Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp b/Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp
@@ -33,6 +33,7 @@
 #include "APIPageConfiguration.h"
 #include "WPEWebViewPlatform.h"
 #include "WebFramePolicyListenerProxy.h"
+#include "WebInspectorUIProxyGLib.h"
 #include "WebPageGroup.h"
 #include "WebPageProxy.h"
 #include "WebPreferences.h"
@@ -46,6 +47,7 @@
 #include <wtf/FileSystem.h>
 #include <wtf/glib/GRefPtr.h>
 #include <wtf/glib/GUniquePtr.h>
+#include <wtf/text/MakeString.h>
 #include <wtf/text/WTFString.h>
 
 namespace WebKit {
@@ -230,9 +232,45 @@ void WebInspectorUIProxy::platformShowCertificate(const WebCore::CertificateInfo
     notImplemented();
 }
 
-void WebInspectorUIProxy::platformSave(Vector<WebCore::InspectorFrontendClient::SaveData>&&, bool /* forceSaveAs */)
+static String computeContentHash(const String& content, bool base64Encoded)
 {
-    notImplemented();
+    GUniquePtr<char> digest;
+    if (base64Encoded) {
+        auto decoded = base64Decode(content);
+        if (decoded)
+            digest.reset(g_compute_checksum_for_data(G_CHECKSUM_SHA256, decoded->span().data(), decoded->size()));
+    } else {
+        CString utf8 = content.utf8();
+        digest.reset(g_compute_checksum_for_string(G_CHECKSUM_SHA256, utf8.data(), utf8.length()));
+    }
+
+    return String::fromUTF8(digest.get());
+}
+
+void WebInspectorUIProxy::platformSave(Vector<WebCore::InspectorFrontendClient::SaveData>&& saveDatas, bool forceSaveAs)
+{
+    ASSERT(saveDatas.size() == 1);
+    UNUSED_PARAM(forceSaveAs);
+
+    // Some inspector views (Audits for instance) use a custom URI scheme, such
+    // as web-inspector. So we can't rely on the URL being a valid file:/// URL
+    // unfortunately.
+    URL url { saveDatas[0].url };
+    auto filename = url.path().substring(1).utf8();
+
+    const gchar* downloadsDir = g_get_user_special_dir(G_USER_DIRECTORY_DOWNLOAD);
+    if (!downloadsDir) {
+        // If we don't have XDG user dirs info, set just to HOME.
+        downloadsDir = g_get_home_dir();
+    }
+
+    auto hash = computeContentHash(saveDatas[0].content, saveDatas[0].base64Encoded);
+
+    auto updatedFilename = makeString(filename, "-"_s, hash.left(8)).utf8();
+
+    GRefPtr<GFile> file = adoptGRef(g_file_new_build_filename(downloadsDir, updatedFilename.data(), nullptr));
+
+    platformSaveDataToFile(WTF::move(file), saveDatas[0].content, saveDatas[0].base64Encoded);
 }
 
 void WebInspectorUIProxy::platformLoad(const String&, CompletionHandler<void(const String&)>&& completionHandler)
diff --git a/Source/WebKit/WebProcess/Inspector/wpe/WebInspectorUIWPE.cpp b/Source/WebKit/WebProcess/Inspector/wpe/WebInspectorUIWPE.cpp
@@ -39,8 +39,17 @@ void WebInspectorUI::didEstablishConnection()
     WTF::registerInspectorResourceIfNeeded();
 }
 
-bool WebInspectorUI::canSave(InspectorFrontendClient::SaveMode)
+bool WebInspectorUI::canSave(InspectorFrontendClient::SaveMode saveMode)
 {
+    switch (saveMode) {
+    case InspectorFrontendClient::SaveMode::SingleFile:
+        return true;
+
+    case InspectorFrontendClient::SaveMode::FileVariants:
+        return false;
+    }
+
+    ASSERT_NOT_REACHED();
     return false;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,17 @@ void WebInspectorUI::didEstablishConnection()`
`39`	`39`	`WTF::registerInspectorResourceIfNeeded();`
`40`	`40`	`}`
`41`	`41`
`42`		`-bool WebInspectorUI::canSave(InspectorFrontendClient::SaveMode)`
	`42`	`+bool WebInspectorUI::canSave(InspectorFrontendClient::SaveMode saveMode)`
`43`	`43`	`{`
	`44`	`+ switch (saveMode) {`
	`45`	`+ case InspectorFrontendClient::SaveMode::SingleFile:`
	`46`	`+ return true;`
	`47`	`+`
	`48`	`+ case InspectorFrontendClient::SaveMode::FileVariants:`
	`49`	`+ return false;`
	`50`	`+ }`
	`51`	`+`
	`52`	`+ ASSERT_NOT_REACHED();`
`44`	`53`	`return false;`
`45`	`54`	`}`
`46`	`55`