This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Let featured images forever be known as featured media#2044
Merged
danielbachhuber merged 1 commit intodevelopfrom Jan 21, 2016
Merged
Let featured images forever be known as featured media#2044danielbachhuber merged 1 commit intodevelopfrom
danielbachhuber merged 1 commit intodevelopfrom
Conversation
Why shouldn't you be able to feature other media too?
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
|
My only concern here is that we are telling clients "this is a piece of media", so the client then needs to work out if it's some media it can display as an image. I know that's probably the case right now (technically) as I could have an audio object as the "feature image", but given it's stored in the db as Thumbnail ID, I don't know if there's a legitimate case for saying WordPress will support anything other than images in that (protected) meta key. |
Member
Author
|
Should we change the |
Member
Author
|
We're sticking with |
danielbachhuber
added a commit
that referenced
this pull request
Jan 21, 2016
Let featured images forever be known as featured media
filose
added a commit
to filose/better-rest-api-featured-images
that referenced
this pull request
Jan 26, 2016
… version 2.0 Beta 11, further info: WP-API/WP-API#2044
jeherve
added a commit
to jeherve/rest-api-post-embeds
that referenced
this pull request
Feb 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why shouldn't you be able to feature other media too?
Fixes #2033