Skip to content

WP/DiscouragedConstants: add XML documentation#2680

Merged
dingo-d merged 2 commits intoWordPress:developfrom
rodrigoprimo:docs-discouraged-constants
Feb 2, 2026
Merged

WP/DiscouragedConstants: add XML documentation#2680
dingo-d merged 2 commits intoWordPress:developfrom
rodrigoprimo:docs-discouraged-constants

Conversation

@rodrigoprimo
Copy link
Collaborator

@rodrigoprimo rodrigoprimo commented Dec 25, 2025

Description

This PR adds XML documentation for the WordPress.WP.DiscouragedConstants sniff.

The documentation is based on the work started by @RafaelFunchal in #2493 and @paulopmt1 in #2589. I squashed the original commits and, in a separate commit, made subsequent changes based on the review left in #2589.

I suggest squashing those two commits before merging. I'm opening the PR without doing that to make it easier to tell my changes apart from the original changes.

Suggested changelog entry

N/A

Related issues/external references

Related to: #1722
Supersedes #2589 and #2493
Closes #2589
Closes #2493

RafaelFunchal and others added 2 commits December 25, 2025 10:10
Co-authored-by: paulopmt1 <paulopmt1@users.noreply.github.com>
Co-authored-by: RafaelFunchal <RafaelFunchal@users.noreply.github.com>
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @rodrigoprimo. LGTM.

@jrfnl jrfnl added this to the 3.3.x milestone Jan 29, 2026
@dingo-d dingo-d merged commit a3f1eed into WordPress:develop Feb 2, 2026
31 checks passed
@rodrigoprimo rodrigoprimo deleted the docs-discouraged-constants branch February 2, 2026 12:28
@jrfnl jrfnl modified the milestones: 3.3.x, 3.4.0 Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants