Remove fill="none" from levelUp icon#50264
Merged
talldan merged 1 commit intoWordPress:trunkfrom May 3, 2023
Merged
Conversation
Member
Author
|
Thanks for the review, @ndiego and reminding me that there's a storybook area for icons as well 😅 I totally forgot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This removes
fill="none"from this SVG.Why?
There's a little bug in this icon file making the icon invisible when you import it in. Removing
fill="none"fixes the issues and makes it the same as other icons.Testing Instructions
levelUpfrom the icons library without this PR, and see that the icon is invisiblelevelUpfrom the icons library with this PR, and see that the icon now shows up.I'm not sure if there is some build scripts or anything I have to run in order for this PR to be successful, if someone could let me know, that'd be helpful!