Removed color.__experimentalDuotone from core blocks#58241
Removed color.__experimentalDuotone from core blocks#58241t-hamano merged 3 commits intoWordPress:trunkfrom
color.__experimentalDuotone from core blocks#58241Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sabbir1991! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Hi @sabbir1991, All the changes made in this PR look correct, but there are conflicts, could you rebase this PR? Thank you for your efforts! |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
8158083 to
5e938e2
Compare
|
Hi @t-hamano, I have rebased the changes with the latest trunk and updated the PR. Now this PR change is ready for review. |
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your work 👍
* Removed `color.__experimentalDuotone` from core blocks * Fixed doc build issue * Updated selector for rendering dutone filter on cover block globally Co-authored-by: sabbir1991 <sabbir1991@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
In this PR I removed the
color.__experimentalDuotonefrom a few core blocks( Avatar, Cover, Post author, Post featured image, and Site logo blocks ) and addedfilter.duotonesupports.Why?
The block supports color.__experimentalDuotone has been deprecated in WordPress 6.3. Thats why I removed those deprecated code and added filter support.
Fixes issue: #58035
Testing Instructions