Fix Category List Block: Add optional chaining to taxonomy name#69703
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Mar 26, 2025
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Mar 26, 2025
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Thank you, @Mayank-Tripathi32!
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…errors (WordPress#69703) Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: hagege <hage@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69697
What?
This PR adds optional chaining (?.) for the name and labels.singular_name properties in the taxonomy object to prevent potential undefined errors.
Why?
Without optional chaining, the block may throw an error when the taxonomy data is unavailable or not properly set. This issue is noticeable when using the Category List block inside a pattern, particularly when enabling "Show as dropdown" and "Show empty values" options.
How?
The implementation adds optional chaining in relevant areas where the taxonomy object or its properties are accessed:
These changes ensure that the block does not break when the taxonomy object is missing or incomplete.
Testing Instructions
ScreenCast
If it does not load then it would show (undefined) - Rarely
