Fix issue of css affecting the nested accordion icon.#71445
Fix issue of css affecting the nested accordion icon.#71445t-hamano merged 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @levinbaria! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
For code readability, we can reuse the existing CSS selector. How about writing it like this?\
.wp-block-accordion-content.is-open {
grid-template-rows: max-content 1fr;
> .wp-block-accordion-header .accordion-content__toggle-icon.has-icon-plus {
transform: rotate(45deg);
}
}|
Yes, that a good catch @t-hamano, I will update the CSS accordingly |
What?
Closes #71435
Fixes CSS selector affects the nested Accordion block icon.
Why?
The Accordion block can be nested, and in that some CSS selector affects the nested Accordion block icon.
How?
Made the CSS selector to apply only on the direct child only.
Testing Instructions
Insert an Accordion block.
Insert an additional Accordion block inside the Accordion panel.
Select the parent Accordion Content block.
Confirm that both toggle icons are rotated.
Testing Instructions for Keyboard
Screenshots or screencast