Site Tagline : Migrate to Text-Align Block Support#75690
Merged
Conversation
shail-mehta
added
[Type] Enhancement
|
Size Change: +120 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7f41839. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22146567719
|
shail-mehta
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
26 tasks
t-hamano
reviewed
Feb 19, 2026
| "attributes": { | ||
| "textAlign": "center" | ||
| } | ||
| "viewportWidth": 350 |
Contributor
There was a problem hiding this comment.
Text positioning should be maintained according to the new block support.
"example": {
"viewportWidth": 350,
"attributes": {
"style": {
"typography": {
"textAlign": "center"
}
}
}
}
Mamaduka
reviewed
Feb 19, 2026
| const blockProps = useBlockProps( { | ||
| className: clsx( { | ||
| [ `has-text-align-${ textAlign }` ]: textAlign, | ||
| 'wp-block-site-tagline__placeholder': ! canUserEdit && ! tagline, |
Member
There was a problem hiding this comment.
Why are we removing the wp-block-site-tagline__placeholder class?
Member
Author
|
Thank you for the review. I mistakenly removed the placeholder class, and I will update the PR to include both corrections. |
shail-mehta
force-pushed
the
migrate/site-tagline-text-align
branch
from
7f41839 to
94c2f3d
Compare
Member
Author
|
I have included both corrections in the latest commit. |
t-hamano
reviewed
Feb 23, 2026
| 'wp-block-site-tagline__placeholder': ! canUserEdit && ! tagline, | ||
| } ), | ||
| className: | ||
| ! canUserEdit && ! tagline |
Contributor
There was a problem hiding this comment.
Nit: It can be simpler
const blockProps = useBlockProps( {
className:
! canUserEdit && ! tagline && 'wp-block-site-tagline__placeholder',
} );
shail-mehta
force-pushed
the
migrate/site-tagline-text-align
branch
from
6cb8d85 to
cdde329
Compare
Member
Author
|
I have simplified the condition as mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #60763
Migrates the
Site Taglineblock to use the textAlign block support instead of a customtextAlignattribute. As a consequence it also enables global styles support fortextAlignfor theSite Tagline.Why?
The
Site Taglineblock currently implements its own text alignment logic with a custom align attribute, duplicating code that should be handled by the centralizedSite Taglineblock support. This migration reduces code duplication and consolidates alignment handling across blocks.How?
Replaces the custom logic with the block supports, adds deprecation and fixes transforms.
Testing Instructions
Site Taglineblock and test text alignment (left, center, right)Site Taglineblocks that have alignment set