Only show dot divider for parent selector in top toolbar#75710
Only show dot divider for parent selector in top toolbar#75710tellthemachines merged 3 commits intotrunkfrom
Conversation
|
Size Change: -24 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b78a678. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22168574376
|
|
Ah, there was a similar issue here - #74329 (comment) TBH, I didn't test with text labels when approving that PR, I should've done if I'd looked at the change more closely. It's weird that the css added as part of the fix (3d5b02b) in that PR is what needs to be removed here. I wonder why it was added. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
Should this be back ported to core? |
Yes please! The bug exists in core trunk right now. |
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: 03613ae |
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>



What?
Removes dot appearing after parent selector when button text labels are enabled in floating block toolbar:
The CSS removed only applies to the floating toolbar, because it's inside a
.components-popover.block-editor-block-list__block-popoverselector. The styles for the top toolbar dot are coming from elsewhere.Testing Instructions