Search block: double-encodes apostrophes in the input value#76023
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Mar 2, 2026
Merged
Conversation
…s `false` to `get_search_query()` so it returns the unescaped\nquery string. `WP_HTML_Tag_Processor::set_attribute()` already\nhandles attribute escaping, so pre-escaping from `get_search_query()`\ncaused double-encoding (e.g. `ada&WordPress#39;s` instead of `ada's`).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
pushed a commit
that referenced
this pull request
Mar 3, 2026
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: katag9k <katag9k@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #76010
What?
Fixes the double-encoding of special characters (e.g., apostrophes) in the Search block's input field on the search results page.
Why?
When searching for a term containing an apostrophe (e.g., "ada's"), the search input field on the results page displays ada's instead of ada's. This happens because get_search_query() returns a pre-escaped string (via esc_attr()), and WP_HTML_Tag_Processor::set_attribute() escapes it again, causing double-encoding.
How?
Pass false to get_search_query() in index.php so it returns the raw, unescaped query string. WP_HTML_Tag_Processor::set_attribute() already handles attribute escaping internally, so the single round of escaping is sufficient and correct.
Testing Instructions
Testing Instructions for Keyboard
Screencast
Search.v2.mov