Image: Replace 'getEntityRecordPermissions` with 'canUser'#76125
Merged
Image: Replace 'getEntityRecordPermissions` with 'canUser'#76125
Conversation
Use the public 'canUser' selector instead of the private 'getEntityRecordPermissions'. Gate the check on 'imageRecord' availability to avoid fetching permissions before the record is loaded.
Mamaduka
added
[Type] Performance
Mamaduka
requested review from
andrewserong
and removed request for
ajitbohra and
fabiankaegy
|
Size Change: -10 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2e5ab67. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22657610427
|
andrewserong
approved these changes
Mar 4, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Nice follow-up, thanks for catching this!
Waiting for imageRecord ensures there's no separate OPTIONS requests. Selector will use pre-resolved data. It also ensures we don't display control if media is missing.
Waiting for imageRecord seems to be the key that I was missing when I tried it last time, thanks for digging in!
LGTM 🚀
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #74601.
Use the public
canUserselector instead of the privategetEntityRecordPermissions. Gate the check onimageRecordavailability to avoid fetching permissions before the record is loaded.Why?
canUserdirectly should be preferred, just checking a single permission.OPTIONSrequests. Selector will use pre-resolved data. It also ensures we don't display control if media is missing.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast