chore: Apply automatic linter formatter and updated associated Composer packages#799
chore: Apply automatic linter formatter and updated associated Composer packages#799georgestephanis merged 5 commits intomasterfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| <!-- Ensure all PHP code is compatible with PHP 7.2 and higher (see upgrade policy in README). --> | ||
| <rule ref="PHPCompatibilityWP" /> | ||
| <config name="testVersion" value="5.6-"/> | ||
| <config name="testVersion" value="7.2-"/> |
There was a problem hiding this comment.
This now matches the plugin header info.
|
@masteradhoc Could you please review this? |
georgestephanis
left a comment
georgestephanis
left a comment
There was a problem hiding this comment.
The review becomes a lot quicker if I hide whitespace changes, but even those look reasonable and good for internal consistency.
|
Added merge commit to handle conflict around phpdoc comment from #793 |
| 2000000000 => ['69279037', '90698825', '38618901'], | ||
| 20000000000 => ['65353130', '77737706', '47863826'] | ||
| ]; | ||
| private static $vectors = array( |
There was a problem hiding this comment.
changed based on https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#declaring-arrays - looks good!
|
Looks great @kasparsd :) |
3 participants
What?
npm run format.Why?
How?
Testing Instructions
Screenshots or screencast
Changelog Entry