fix(ui): change background color for code block to --bs-secondary-bg#1398
fix(ui): change background color for code block to --bs-secondary-bg#1398shuashuai merged 1 commit intoapache:devfrom
Conversation
|
PRs should be submitted to the dev branch. You can clean up locally and then force push. |
|
hey @sy-records , could you please review the PR? |
There was a problem hiding this comment.
The background color of the pre tag in the design draft is gray-100, so no adjustment should be needed here. It would be more appropriate to adapt the colors for dark mode.
The color matching here is consistent with the background color of the comment area, so go to ui/src/common/color.scss to make a separate adaptation.
Or modify the color of --an-pre in light mode to be consistent with bg-light, and then use --an-pre for the background color of the pre tag.
eg:

You can choose either of the two methods above.
|
@shuashuai thank you for the guidance. I've gone for the route of editing --an-pre's value and using it instead of writing a separate property so that the --an-pre variable could also be used at other places (with the correct color value). |
shuashuai
left a comment
There was a problem hiding this comment.
Thank you for your contribution!

fix : #1368